Feature: Multi-Attach for io2 block devices #1799

torredil · 2023-10-25T01:25:30Z

Is this a bug fix or adding new feature?

New feature
Closes CSI support attach a volume to multiple instances with amazon EBS Multi-Attach #449

What is this PR about? / Why do we need it?

This PR implements the ability to enable multi-attach for io2 block devices by specifying the ReadWriteMany access mode in PersistentVolumeClaim.spec.accessModes. A few important points to note:

EBS Multi-Attach does not support standard file systems. Standard file systems such as xfs, ext3, ext4, and NTFS aren't designed to be simultaneously accessed by multiple EC2 instances.
Simultaneous access to a standard file system can result in data corruption or data loss.
Multi-Attach is only enabled for io2 block devices.

See the documentation: https://github.com/torredil/aws-ebs-csi-driver/blob/d316ff830997cb38d17e38625cbaeea2e089068a/docs/multi-attach.md

What testing is done?

Unit tests: make test
e2e tests:

$ ginkgo run --focus='multi-attach' --v&

Ran 3 of 42 Specs in 82.685 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 39 Skipped

External.Storage suite

docs/multi-attach.md

pkg/cloud/cloud.go

tests/e2e/multi_attach.go

pkg/cloud/cloud.go

wmesard

I think we need some static provisioning test cases.

If multi-attach is not enabled on an existing volume, obviously mult-attach should fail. So we should have an expected-fail test.
For this release, I believe that we are only intending to support multi-attach in dynamically provisioned volumes. If that's true, then we should enforce that, and have a test for that enforcement. If we decide that we'll handle the case where a statically provisioned volume has multi-attach enabled, then we should have an expected-success test for that.

docs/multi-attach.md

pkg/cloud/cloud.go

pkg/driver/controller.go

tests/e2e/multi_attach.go

k8s-ci-robot · 2023-10-26T13:50:38Z

@wmesard: changing LGTM is restricted to collaborators

In response to this:

I think we need some static provisioning test cases.

If multi-attach is not enabled on an existing volume, obviously mult-attach should fail. So we should have an expected-fail test.

For this release, I believe that we are only intending to support multi-attach in dynamically provisioned volumes. If that's true, then we should enforce that, and have a test for that enforcement. If we decide that we'll handle the case where a statically provisioned volume has multi-attach enabled, then we should have an expected-success test for that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

torredil · 2023-10-31T16:27:07Z

CI is green and this PR is now ready for another round in the ring : )

cc: @wmesard @ConnorJC3 @AndrewSirenko

k8s-ci-robot · 2023-11-02T03:15:47Z

@wmesard: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/cloud/cloud.go

pkg/driver/internal/inflight.go

pkg/driver/node.go

pkg/cloud/cloud.go

Signed-off-by: Eddie Torres <[email protected]>

ConnorJC3 · 2023-11-06T20:00:13Z

/lgtm

AndrewSirenko · 2023-11-07T00:33:35Z

/lgtm

torredil · 2023-11-07T13:45:42Z

/approve

k8s-ci-robot · 2023-11-07T13:45:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [torredil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Reference: kubernetes-sigs/aws-ebs-csi-driver#1799 Signed-off-by: Arnon Gilboa <[email protected]>

Reference: kubernetes-sigs/aws-ebs-csi-driver#1799 Signed-off-by: Arnon Gilboa <[email protected]> Co-authored-by: Arnon Gilboa <[email protected]>

Reference: kubernetes-sigs/aws-ebs-csi-driver#1799 Signed-off-by: Arnon Gilboa <[email protected]>

Reference: kubernetes-sigs/aws-ebs-csi-driver#1799 Signed-off-by: Arnon Gilboa <[email protected]> Co-authored-by: Arnon Gilboa <[email protected]>

k8s-ci-robot requested review from AndrewSirenko and ConnorJC3 October 25, 2023 01:25

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 25, 2023

torredil force-pushed the multi-attach-7123 branch 2 times, most recently from f109d19 to 5918d0b Compare October 25, 2023 13:10

AndrewSirenko reviewed Oct 25, 2023

View reviewed changes

docs/multi-attach.md Show resolved Hide resolved

docs/multi-attach.md Outdated Show resolved Hide resolved

docs/multi-attach.md Show resolved Hide resolved

pkg/cloud/cloud.go Outdated Show resolved Hide resolved

tests/e2e/multi_attach.go Outdated Show resolved Hide resolved

AndrewSirenko reviewed Oct 25, 2023

View reviewed changes

pkg/cloud/cloud.go Outdated Show resolved Hide resolved

wmesard suggested changes Oct 26, 2023

View reviewed changes

torredil force-pushed the multi-attach-7123 branch 7 times, most recently from 337e89a to b84d4ec Compare October 30, 2023 20:20

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 30, 2023

torredil force-pushed the multi-attach-7123 branch 5 times, most recently from 0eb06fe to 222c4c3 Compare October 31, 2023 15:53

torredil force-pushed the multi-attach-7123 branch from 222c4c3 to 9ea4083 Compare November 1, 2023 12:43

ConnorJC3 force-pushed the master branch 2 times, most recently from 24a8e7b to bddbe0b Compare November 1, 2023 18:08

wmesard approved these changes Nov 2, 2023

View reviewed changes

ConnorJC3 reviewed Nov 6, 2023

View reviewed changes

pkg/cloud/cloud.go Show resolved Hide resolved

pkg/driver/internal/inflight.go Outdated Show resolved Hide resolved

pkg/driver/node.go Outdated Show resolved Hide resolved

pkg/cloud/cloud.go Outdated Show resolved Hide resolved

torredil force-pushed the multi-attach-7123 branch from 9ea4083 to a118ac8 Compare November 6, 2023 18:13

Feature: Multi-Attach for io2 block devices

76a68ba

Signed-off-by: Eddie Torres <[email protected]>

torredil force-pushed the multi-attach-7123 branch from a118ac8 to 76a68ba Compare November 6, 2023 19:57

k8s-ci-robot assigned ConnorJC3 Nov 6, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2023

k8s-ci-robot assigned AndrewSirenko Nov 7, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023

k8s-ci-robot merged commit 27d1a99 into kubernetes-sigs:master Nov 7, 2023
8 checks passed

jsafrane mentioned this pull request Nov 21, 2023

STOR-1400: Rebase to v1.25.0 for OCP 4.15 openshift/aws-ebs-csi-driver#244

Merged

arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request Nov 18, 2024

Add RWX to AWS EBS io2 capabilities

be7d684

Reference: kubernetes-sigs/aws-ebs-csi-driver#1799 Signed-off-by: Arnon Gilboa <[email protected]>

arnongilboa mentioned this pull request Nov 18, 2024

Add RWX to AWS EBS io2 capabilities kubevirt/containerized-data-importer#3528

Merged

kubevirt-bot pushed a commit to kubevirt/containerized-data-importer that referenced this pull request Nov 18, 2024

Add RWX to AWS EBS io2 capabilities (#3528)

448fe9d

Reference: kubernetes-sigs/aws-ebs-csi-driver#1799 Signed-off-by: Arnon Gilboa <[email protected]>

kubevirt-bot pushed a commit to kubevirt-bot/containerized-data-importer that referenced this pull request Nov 19, 2024

Add RWX to AWS EBS io2 capabilities

e8fd2a9

Reference: kubernetes-sigs/aws-ebs-csi-driver#1799 Signed-off-by: Arnon Gilboa <[email protected]>

kubevirt-bot pushed a commit to kubevirt-bot/containerized-data-importer that referenced this pull request Nov 21, 2024

Add RWX to AWS EBS io2 capabilities

ac20909

Reference: kubernetes-sigs/aws-ebs-csi-driver#1799 Signed-off-by: Arnon Gilboa <[email protected]>

kubevirt-bot pushed a commit to kubevirt-bot/containerized-data-importer that referenced this pull request Nov 21, 2024

Add RWX to AWS EBS io2 capabilities

2f86292

Reference: kubernetes-sigs/aws-ebs-csi-driver#1799 Signed-off-by: Arnon Gilboa <[email protected]>

This was referenced Dec 30, 2024

Kubernets: introduce production ready volume management ITISFoundation/osparc-ops-environments#855

Open

Kubernets: Introduce prod-ready volume management on AWS clusters ITISFoundation/osparc-ops-environments#918

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Multi-Attach for io2 block devices #1799

Feature: Multi-Attach for io2 block devices #1799

torredil commented Oct 25, 2023 •

edited

Loading

wmesard left a comment

k8s-ci-robot commented Oct 26, 2023

torredil commented Oct 31, 2023

k8s-ci-robot commented Nov 2, 2023

ConnorJC3 commented Nov 6, 2023

AndrewSirenko commented Nov 7, 2023

torredil commented Nov 7, 2023

k8s-ci-robot commented Nov 7, 2023

Feature: Multi-Attach for io2 block devices #1799

Feature: Multi-Attach for io2 block devices #1799

Conversation

torredil commented Oct 25, 2023 • edited Loading

wmesard left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 26, 2023

torredil commented Oct 31, 2023

k8s-ci-robot commented Nov 2, 2023

ConnorJC3 commented Nov 6, 2023

AndrewSirenko commented Nov 7, 2023

torredil commented Nov 7, 2023

k8s-ci-robot commented Nov 7, 2023

torredil commented Oct 25, 2023 •

edited

Loading